Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor: Migrate Icons to React Icons #137

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Refactor: Migrate Icons to React Icons #137

wants to merge 3 commits into from

Conversation

SimplementeCao
Copy link

Pull Request for SafeTrust - Close Issue

❗ Pull Request Information

Replace the following image files with equivalent icons from React Icons:

Frontend\public\img\Icon.svg
Frontend\public\img\icon1.jpg
Frontend\public\img\icon2.jpg

React Icon equivalents:

image

image

image

🌀 Summary of Changes

  • Add here the changes:

  • Import new React Icon

  • Use new React icon changing the labels

  • More changes:

  • Deleted the Icon.svg file

  • Deleted the icon1.png file

  • Deleted the icon2.png file

🛠 Testing

Evidence Before Solution

Evidence After Solution

📂 Related Issue

This pull request will **close #132 ** upon merging.

🎉 Thank you for reviewing this PR! 🎉

@SimplementeCao SimplementeCao changed the title add reactIcon + remove images Feat: Migrate Icons to React Icons Dec 14, 2024
@zleypner
Copy link
Contributor

zleypner commented Dec 16, 2024 •
edited
Loading

Hello @SimplementeCao , Than you for your contribution.
I will proceed to review asap.

@zleypner
Copy link
Contributor

zleypner commented Dec 16, 2024 •
edited
Loading

Hello @SimplementeCao , Please update the commits based in the Git Guideline.

@SimplementeCao SimplementeCao changed the title Feat: Migrate Icons to React Icons Refactor: Migrate Icons to React Icons Dec 16, 2024
@SimplementeCao
Copy link
Author

hi @zleypner I have already made the changes in the commit, thx

@zleypner
Copy link
Contributor

Awesome, Thank You! Checking.

@zleypner
Copy link
Contributor

Hello @SimplementeCao , Please resolve the conflicts.

@zleypner zleypner self-requested a review December 19, 2024 06:11
@zleypner
Copy link
Contributor

Hello @SimplementeCao ! Would you be so kind to proceed with the updates requested?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zleypner zleypner zleypner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Migrate Icons to React Icons
2 participants
@SimplementeCao @zleypner